Skip to content

refactor: ensure /mnt has free space before running tests in CI #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

refactor: ensure /mnt has free space before running tests in CI #3731

merged 1 commit into from
Jul 14, 2025

Conversation

jarhodes314
Copy link
Contributor

Proposed changes

Make sure that /mnt has some free space before we attempt to write something to it in the unit tests following the changes introduced by #3726. Occasionally this disk is full before we start the run, and this causes the unit tests attempting to write to the disk to fail.

An example of the failure can be seen here, noting that there is no available space on /mnt when we check it at the start of workflow: https://github.com/thin-edge/thin-edge.io/actions/runs/16200614562/job/45738409871.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request July 14, 2025 14:15 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller
Copy link
Contributor

reubenmiller commented Jul 14, 2025 •
edited
Loading

@jarhodes314 Do we have an idea what is already existing under /mnt, I'm more think of if this workflow would be to run on a self-hosted runner, then deleting /mnt/ is pretty extreme.

update
Maybe not as extreme as I first thought, but still would be good to know what is under the directory

@jarhodes314
Copy link
Contributor Author

I don't know exactly what's under the directory, but agree this would likely be problematic for a self hosted runner. I think the answer boils down to depending on how GitHub spins up Azure VMs for running actions on and what's run on the runner before, there could be all manner of things in /mnt.

By default, I think all that's in /mnt is a swapfile and a README from the underlying Azure VM telling you not to rely on the data persisting after a reboot of the VM (which doesn't affect us).

@reubenmiller
Copy link
Contributor

reubenmiller commented Jul 14, 2025 •
edited
Loading

I don't know exactly what's under the directory, but agree this would likely be problematic for a self hosted runner. I think the answer boils down to depending on how GitHub spins up Azure VMs for running actions on and what's run on the runner before, there could be all manner of things in /mnt.

By default, I think all that's in /mnt is a swapfile and a README from the underlying Azure VM telling you not to rely on the data persisting after a reboot of the VM (which doesn't affect us).

Ok, then I guess that should be fine for now, we could potentially add a check against the runner type (to prevent running the command on an unexpected environment)

@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
654 0 3 654 100 1h49m50.677996999s

@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label Jul 14, 2025
reubenmiller
reubenmiller approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The job is already marked to only run on runs-on: ubuntu-22.04, so we should be ok

@jarhodes314 jarhodes314 added this pull request to the merge queue Jul 14, 2025
Merged via the queue into thin-edge:main with commit fc0f092 Jul 14, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

@Bravo555 Bravo555 Awaiting requested review from Bravo555 Bravo555 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees
No one assigned
Labels
ci/cd Repository management and pipeline topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarhodes314 @reubenmiller