Skip to content

Conversation

jarhodes314
Copy link
Contributor

Proposed changes

In order to get the unit tests running successfully on #3717, we need the download tests to have more disk space available. They are currently failing since they require the disk to have at least 5% free disk space in order for them to start a download.

These changes change the directory for the temporary files in the unit tests to be a subdirectory of /mnt, which is a separate disk on the github actions runner. This should mean that the tests don't fail due to InsufficientSpace in tedge_downloader_ext and therefore #3717 can be merged.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request July 10, 2025 13:19 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label Jul 10, 2025
Copy link
Contributor

github-actions bot commented Jul 10, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
654 0 3 654 100 1h47m59.557872999s

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request July 10, 2025 14:53 — with GitHub Actions Inactive
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jarhodes314 jarhodes314 enabled auto-merge July 10, 2025 15:33
@jarhodes314 jarhodes314 added this pull request to the merge queue Jul 10, 2025
Merged via the queue into thin-edge:main with commit c3c7b24 Jul 10, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants