Skip to content

[Physics] Fix inconsistent box2D collision, see #1707 and #2019 #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2024
Merged

[Physics] Fix inconsistent box2D collision, see #1707 and #2019 #2092

merged 1 commit into from
Jan 7, 2024

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Jan 3, 2024

PR Details

See title.

Related Issue

Fixes #2019

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Copy link
Collaborator Author

Eideren commented Jan 3, 2024

Pinging @VaclavElias @Jklawreszuk for insight.
Right now I have gone through Character Controller->Static Collider for both box/box and sphere/sphere and rigidbody->static collider for box/box with continuous collision detection with the repro provided in the first post of #2019. If you have other cases you think might be worthwhile to test please go ahead.

@Eideren Eideren mentioned this pull request Jan 3, 2024
Closed
@Eideren Eideren merged commit 8f20f77 into stride3d:master Jan 7, 2024
@Eideren Eideren deleted the fix_2d_physics branch January 7, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Physics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2D collision issue - clipping through
2 participants
@Eideren @VaclavElias