fix(progressiveLightMap): add normal validation and preserve flatShading #31800
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added error checks to ensure all meshes have vertex normals or flat shading - Fixed issue where flatShading setting from original material was lost - New materials now correctly inherit flatShading from the original material
Mugen87
reviewed
Sep 2, 2025
| @@ -205,6 +211,10 @@ class ProgressiveLightMap { | |||
| // Set each object's material to the UV Unwrapped Surface Mapping Version | |||
| for ( let l = 0; l < this.lightMapContainers.length; l ++ ) { | |||
|
|
|||
| // Ensure the object has correct flatShading | |||
| const flatShading = this.lightMapContainers[ l ].basicMat.flatShading; | |||
| this.uvMat.flatShading = flatShading; | |||
There was a problem hiding this comment.
There is only a single uvMat material which is assigned to all objects in the light map container. basicMat represents the original material of each object. So you can't assign a property value which might be different for all original materials to the shared uvMat instance.
Mugen87
reviewed
Sep 2, 2025
| @@ -123,6 +123,12 @@ class ProgressiveLightMap { | |||
|
|
|||
| } | |||
|
|
|||
| if ( !object.material.flatShading && !object.geometry.hasAttribute( 'normal' ) ) { | |||
There was a problem hiding this comment.
Let's change this to:
if ( object.material.flatShading === false && object.geometry.hasAttribute( 'normal' ) === false ) {|
Closing in favor of #31825. It's a good addition to implement a check for vertex normals however it is somewhat out of scope to make the uv material compatible with all possible material permutations. Feel free to enhance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: (#31799)
Description
Some models use materials with flatShading = true while their geometries do not contain vertex normals.
In the main scene, these models render correctly because flatShading does not require vertex normals.
In ProgressiveLightMap, however, the material was replaced with an internal uvMat that had flatShading = false. This caused the affected objects to render completely black.
Additionally, when a material had flatShading = false and the geometry had no vertex normals, the code did not throw any warning or error, leading to silent failures.
This fix ensures:
The flatShading value is now correctly inherited from the original material.
If flatShading = false and the geometry has no vertex normals, an error is thrown to prevent silent rendering failures.