Renderers: Use internal log, warn and error functions instead of the system ones
#31790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Sounds good to me 👍 |
|
Why do we need Can't we just do |
This is the interesting part, with
I didn’t understand the purpose, could you explain it to me? |
|
Ah, I think I understand. With Sounds good sounds good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an approach similar to the one used in
warnOnce, but for native console functions such aslog,warn, anderror.The idea is to gain control over the warnings being issued and thus create more advanced systems for these logs, such as monitoring them through functions. This can be very useful if three.js is used in general-purpose tools like editors and inspectors.
The function to set a callback for console functions is
setConsoleFunctionandgetConsoleFunction:The
THREE.prefix is also no longer necessary, as it is automatically added in the intermediate function.