XREstimatedLight: Check session.enabledFeatures (if available) before attempting session.requestLightProbe
#27898
Conversation
…sion.requestLightProbe` The double-negative here is unfortunate, but currently `session.enabledFeatures` is only available in Chromium-based browsers, so we can't always *positively* know that the feature is supported. Another approach would be to wrap `session.requestLightProbe` in try/catch, or add `.catch` after the `.then`, but for whatever reason, those don't seem to actually catch the error for me. Related: immersive-web/webxr#1296
|
On second thought, I think Chromium is the only browser that implements much of anything WebXR-wise (in stable release) right now. Let me know if I should just assume existence of |
|
Do you mind explaining in more detail why the current implementation causes issues for you? I mean what device and browser are you using? Right now |
|
Ah, right, in my case I am requesting the permission, and also adding // wait for session to start, then:
if(session.enabledFeatures.includes('light-estimation')) {
// add XREstimatedLight to scene
}I think that's what you mean - and agreed - this does make more sense. I'll close this - sorry for the noise! |
Description:
The double-negative here is unfortunate, but
session.enabledFeaturesis currently only available in Chromium-based browsers, so we can't always 'positively' know that the feature is supported.Another approach would be to wrap
session.requestLightProbein try/catch, or add.catchafter the.then, but for whatever reason, those don't seem to actually catch theDOMExceptionerror for me.Related: immersive-web/webxr#1296
Motivation:
The thrown error doesn't cause any serious problem - it just errors and fails. But it is annoying when using the "Pause on uncaught exceptions" feature of Chrome DevTools.