Skip to content

Conversation

mloiseleur
Copy link
Collaborator

What does it do ?

Change default of expose-internal-ipv6

Motivation

Follow-up of #5192

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I updated unit tests accordingly
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added docs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2025
@mloiseleur
Copy link
Collaborator Author

cc @hjoshi123 @jonasbadstuebner

@ivankatliarchuk
Copy link
Contributor

Worth to update decision https://github.com/kubernetes-sigs/external-dns/blob/master/docs/proposal/002-internal-ipv6-handling-rollback.md implemented

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2025
@mloiseleur mloiseleur force-pushed the feat/expose-ipv6 branch 2 times, most recently from 2be721d to 32abcde Compare June 26, 2025 12:51
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2025
@ivankatliarchuk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@ivankatliarchuk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@ivankatliarchuk
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2d898cd into kubernetes-sigs:master Jun 27, 2025
14 checks passed
@mloiseleur mloiseleur deleted the feat/expose-ipv6 branch June 27, 2025 10:48
@ivankatliarchuk
Copy link
Contributor

Fixes #4566

troll-os pushed a commit to FiligranHQ/external-dns that referenced this pull request Aug 28, 2025
* feat(nodes)!: expose external ipv6 by default

* update proposal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants