feat(source): optional expose of nodes internal ipv6 #5192

hjoshi123 · 2025-03-17T14:43:34Z

Description

This PR introduces a flag expose-internal-ipv6 according to the proposal IPv6 proposal which states that we are going to implement a flag to allow users to determine if they want to expose their internal IPv6. For the next release, this flag is going to be defaulted as true which means internal IPv6s are exposed (this is how we treat IPv6s currently too). The next minor release will flip the flag and still provide users the option to go back if needed.

Relates #4566
Related pull request #4574
Implement proposal IPv6 proposal

Checklist

Unit tests updated
End user documentation updated

…expose-internal-ipv6

k8s-ci-robot · 2025-03-17T14:43:44Z

Hi @hjoshi123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hjoshi123 · 2025-03-17T14:43:54Z

Will update the documentation soon. Raising PR for visibility.

mloiseleur · 2025-03-17T14:57:04Z

/ok-to-test
/retitle feat(source): optional expose of nodes internal ipv6

mloiseleur · 2025-03-17T14:57:38Z

Thanks @hjoshi123 !

ivankatliarchuk · 2025-03-17T16:20:11Z

Could you add a warning message with the tests, to inform users that in follow-up release we are going to flip the flag/behaviour?

source/node.go

source/node_test.go

ivankatliarchuk · 2025-03-19T07:15:05Z

The Warning message is missing, with description that if users would like to expose private Node IPs, they should configure the flag explicitly. Otherwise with next release, when we flip the flag, external-dns will silently update records for them.

With explicit test, we have a helper for that

external-dns/internal/testutils/log.go

Line 36 in ecd57c8

func LogsToBuffer(level log.Level, t *testing.T) *bytes.Buffer {

docs/sources/nodes.md

pkg/apis/externaldns/types.go

source/node_test.go

hjoshi123 · 2025-03-20T04:22:50Z

/retest

ivankatliarchuk · 2025-03-20T07:31:19Z

source/node_test.go

+		require.NoError(t, err)
+
+		if tc.exposeInternalIPv6 {
+			buf := testutils.LogsToBuffer(log.DebugLevel, t)


should be log.WarningLevel https://sematext.com/blog/logging-levels/

WARNING is not required as well, as

yup will change that

mloiseleur · 2025-03-24T08:01:43Z

This PR LGTM.
@ivankatliarchuk Anything left from your PoV ?
@jonasbadstuebner Do you think you can review this PR ?

jonasbadstuebner

I request to change the behavior back to the original one, when adding the feature flag - I added my suggestion(s).

Sorry for some nits I added. If they are invalid or unnecessary, please let me know.

docs/sources/nodes.md

source/node_test.go

pkg/apis/externaldns/types.go

source/node.go

source/node_test.go

docs/sources/nodes.md

source/node_test.go

k8s-ci-robot · 2025-03-24T09:32:23Z

@jonasbadstuebner: changing LGTM is restricted to collaborators

In response to this:

I request to change the behavior back to the original one, when adding the feature flag - I added my suggestion(s).

Sorry for some nits I added. If they are invalid or unnecessary, please let me know.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jonasbadstuebner · 2025-03-24T09:34:56Z

Thank you @hjoshi123, for taking the time to open this PR, it's greatly appreciated from my side! Even if I added a lot of comments, they are not meant to devalue your work!

source/node.go

k8s-ci-robot · 2025-03-25T18:36:23Z

@jonasbadstuebner: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ivankatliarchuk · 2025-03-25T18:38:23Z

This PR LGTM. @ivankatliarchuk Anything left from your PoV ? @jonasbadstuebner Do you think you can review this PR ?

All good from my side, will approve when other comments resolved

jonasbadstuebner · 2025-03-26T18:41:19Z

It's good to go from my side 🚀 Thank you again, @hjoshi123!

ivankatliarchuk

/lgtm

jonasbadstuebner · 2025-03-26T19:57:11Z

/approve
I guess? :D

jonasbadstuebner · 2025-03-26T19:58:03Z

Ah I misunderstood - I thought I have to approve because there are pending requests by me shown.

ivankatliarchuk · 2025-03-26T20:28:18Z

Everything ls correct. Thanks for reviewing.

We review & approve.

mloiseleur · 2025-03-26T22:25:21Z

@jonasbadstuebner I'm unsure, maybe you will need to approve from Git Hub review tab, in order to remove the requested change.

I'll try and we'll see :)

/approve

k8s-ci-robot · 2025-03-26T22:25:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, jonasbadstuebner, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…o v0.17.0 (#712) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://github.com/kubernetes-sigs/external-dns) | minor | `v0.16.1` -> `v0.17.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.17.0`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.17.0) [Compare Source](kubernetes-sigs/external-dns@v0.16.1...v0.17.0) #### Global information :information_source: On Pi Hole, support for v6 has been added. Pi Hole v5 support is deprecated and will be removed in a future version :information_source: On OVH, the provider has been heavily rewritten. New ACLs are need. See documentation and PR [#5143](kubernetes-sigs/external-dns#5143) for details. :information_source: On IPv6, the [proposal 002](https://github.com/kubernetes-sigs/external-dns/blob/master/docs/proposal/002-internal-ipv6-handling-rollback.md) has been implemented, thanks to [@hjoshi123](https://github.com/hjoshi123) - ⚠️ In the next release, the default of this new `expose-internal-ipv6` flag will be set to false ⚠️ There is a severe known issue with Active Directory ([#5240](kubernetes-sigs/external-dns#5240)) since v0.16.0. PR to fix it ([#5385](kubernetes-sigs/external-dns#5385)) is in review :information_source: The legacy txt-format will be removed in the next minor version ([#5172](kubernetes-sigs/external-dns#5172)) - ⚠️ There is currently no migration script to clean old style txt records. If you need it, if you think you can do it, PRs are welcome. ℹ️ A new Nomad source may be added to external-dns ([#5284](kubernetes-sigs/external-dns#5284)) - This PR can be merged only after a review and test from real Nomad users #### 🚀 Features - feat: additional template functions by [@matkam](https://github.com/matkam) in [#3949](kubernetes-sigs/external-dns#3949) - feat(banner): standardize user agent and output by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5154](kubernetes-sigs/external-dns#5154) - feat(chart): Update image to v0.16.1 by [@stevehipwell](https://github.com/stevehipwell) in [#5201](kubernetes-sigs/external-dns#5201) - feat(cloudflare): multiple custom hostnames support by [@mrozentsvayg](https://github.com/mrozentsvayg) in [#5239](kubernetes-sigs/external-dns#5239) - feat(helm): allow extraArgs to also be a map enabling overrides of individual values by [@frittentheke](https://github.com/frittentheke) in [#5293](kubernetes-sigs/external-dns#5293) - feat: IDNA awareness in the zone finder by [@lexisother](https://github.com/lexisother) in [#5147](kubernetes-sigs/external-dns#5147) - feat(ovh): major rewriting of the provider by [@rbeuque74](https://github.com/rbeuque74) in [#5143](kubernetes-sigs/external-dns#5143) - feat(pihole): add optional support for v6 by [@tJouve](https://github.com/tJouve) in [#5226](kubernetes-sigs/external-dns#5226) - feat(pihole): add support for IPv6 Dual format by [@tJouve](https://github.com/tJouve) in [#5253](kubernetes-sigs/external-dns#5253) - feat(source): optional exclusion of unschedulable nodes by [@Hayajiro](https://github.com/Hayajiro) in [#5045](kubernetes-sigs/external-dns#5045) - feat(source): optional expose of nodes internal ipv6 by [@hjoshi123](https://github.com/hjoshi123) in [#5192](kubernetes-sigs/external-dns#5192) #### 🐛 Bug fixes - fix(aws): typo on route53 IAM by [@tico24](https://github.com/tico24) in [#5197](kubernetes-sigs/external-dns#5197) - fix(chart): add missing types for empty values by [@t3mi](https://github.com/t3mi) in [#5207](kubernetes-sigs/external-dns#5207) - fix(cloudflare): custom hostnames edge-cases causing duplicates by [@mrozentsvayg](https://github.com/mrozentsvayg) in [#5183](kubernetes-sigs/external-dns#5183) - fix(cloudflare): regional hostnames by [@vflaux](https://github.com/vflaux) in [#5175](kubernetes-sigs/external-dns#5175) - fix(Gateway API): ensure generation match by [@davidwin93](https://github.com/davidwin93) in [#5241](kubernetes-sigs/external-dns#5241) - fix(gateway-api): ensure to use only latest generation with HTTPRoutes by [@kashalls](https://github.com/kashalls) in [#5349](kubernetes-sigs/external-dns#5349) - fix(helm): added missing schema values by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5228](kubernetes-sigs/external-dns#5228) - fix(helm): update helm schema by [@semnell](https://github.com/semnell) in [#5297](kubernetes-sigs/external-dns#5297) - fix(log testing): re-use logger library testing functionality by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5368](kubernetes-sigs/external-dns#5368) - fix(node): logger test fixed by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5232](kubernetes-sigs/external-dns#5232) - fix(ovh): handling capitalized DNS records + prevent panic by [@rbeuque74](https://github.com/rbeuque74) in [#5390](kubernetes-sigs/external-dns#5390) - fix(webhook): api json object plan.Changes case by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5355](kubernetes-sigs/external-dns#5355) - fix(zonefinder): handle underscores in dns records by [@arthlr](https://github.com/arthlr) in [#5281](kubernetes-sigs/external-dns#5281) #### 📝 Documentation - docs(contributing): add conventional commits by [@mloiseleur](https://github.com/mloiseleur) in [#5333](kubernetes-sigs/external-dns#5333) - docs(proposal): externaldns api graduation to beta by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5079](kubernetes-sigs/external-dns#5079) - docs(rfc2136): fix env variable in the guideline by [@riupie](https://github.com/riupie) in [#5352](kubernetes-sigs/external-dns#5352) - docs(tutorials): add IONOS Cloud setup tutorial for ExternalDNS by [@smilutinovic-ionos](https://github.com/smilutinovic-ionos) in [#5364](kubernetes-sigs/external-dns#5364) - docs(typo): grcp → grpc by [@octo](https://github.com/octo) in [#5231](kubernetes-sigs/external-dns#5231) - docs: update link to Anexia webhook provider by [@mloiseleur](https://github.com/mloiseleur) in [#5244](kubernetes-sigs/external-dns#5244) - docs: update rfc2136 by [@BasJ93](https://github.com/BasJ93) in [#5325](kubernetes-sigs/external-dns#5325) #### 📦 Others - Add Yandex Cloud Webhook by [@ismailbaskin](https://github.com/ismailbaskin) in [#5190](kubernetes-sigs/external-dns#5190) - chore: add se for nlb, alb in thailand region by [@xshot9011](https://github.com/xshot9011) in [#5200](kubernetes-sigs/external-dns#5200) - chore: fix typo on txtOwnerId comment/description by [@lanandra](https://github.com/lanandra) in [#5351](kubernetes-sigs/external-dns#5351) - chore(ci): fix random data race failure on source/node test by [@mloiseleur](https://github.com/mloiseleur) in [#5268](kubernetes-sigs/external-dns#5268) - chore(ci): improve release script by [@mloiseleur](https://github.com/mloiseleur) in [#5394](kubernetes-sigs/external-dns#5394) - chore(ci): update linter to v2.0.2 by [@mloiseleur](https://github.com/mloiseleur) in [#5246](kubernetes-sigs/external-dns#5246) - chore(code-cleanup): move logic away from main.go add tests by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5222](kubernetes-sigs/external-dns#5222) - chore(code): improve some tests + re-order sources flags CLI by [@mloiseleur](https://github.com/mloiseleur) in [#5288](kubernetes-sigs/external-dns#5288) - chore(code-quality): added lint checks by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5318](kubernetes-sigs/external-dns#5318) - chore(code-quality): providers linter warnings fixes by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5320](kubernetes-sigs/external-dns#5320) - chore(code-quality): refactoring and linter fixes by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5374](kubernetes-sigs/external-dns#5374) - chore(code-quality): webhook increase code coverage by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5337](kubernetes-sigs/external-dns#5337) - chore(crd): use conventional paths and update controller-gen to v0.17.2 by [@mloiseleur](https://github.com/mloiseleur) in [#5287](kubernetes-sigs/external-dns#5287) - chore(dependencies): update toools versions by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5252](kubernetes-sigs/external-dns#5252) - chore(deps): build with go 1.24.2 by [@mloiseleur](https://github.com/mloiseleur) in [#5306](kubernetes-sigs/external-dns#5306) - chore(deps): bump renovatebot/github-action from 41.0.14 to 41.0.16 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5188](kubernetes-sigs/external-dns#5188) - chore(deps): bump renovatebot/github-action from 41.0.16 to 41.0.17 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5210](kubernetes-sigs/external-dns#5210) - chore(deps): bump the dev-dependencies group across 1 directory with 14 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5346](kubernetes-sigs/external-dns#5346) - chore(deps): bump the dev-dependencies group across 1 directory with 14 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5382](kubernetes-sigs/external-dns#5382) - chore(deps): bump the dev-dependencies group across 1 directory with 17 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5238](kubernetes-sigs/external-dns#5238) - chore(deps): bump the dev-dependencies group across 1 directory with 19 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5262](kubernetes-sigs/external-dns#5262) - chore(deps): bump the dev-dependencies group across 1 directory with 20 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5211](kubernetes-sigs/external-dns#5211) - chore(deps): bump the dev-dependencies group across 1 directory with 21 updates by [@mloiseleur](https://github.com/mloiseleur) in [#5313](kubernetes-sigs/external-dns#5313) - chore(deps): bump the dev-dependencies group across 1 directory with 2 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5247](kubernetes-sigs/external-dns#5247) - chore(deps): bump the dev-dependencies group across 1 directory with 2 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5301](kubernetes-sigs/external-dns#5301) - chore(deps): bump the dev-dependencies group across 1 directory with 2 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5323](kubernetes-sigs/external-dns#5323) - chore(deps): code cleanup, pkg/errors is archived by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5335](kubernetes-sigs/external-dns#5335) - chore(deps): switch to goccy yaml by [@Raffo](https://github.com/Raffo) in [#5292](kubernetes-sigs/external-dns#5292) - chore(deps): update linter to v2.1.x by [@mloiseleur](https://github.com/mloiseleur) in [#5366](kubernetes-sigs/external-dns#5366) - chore(fqdn-template): fqdn templating move to specific folder and update documentation by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5354](kubernetes-sigs/external-dns#5354) - chore(github): add a release template by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5324](kubernetes-sigs/external-dns#5324) - chore(helm): add validation for prefix and suffix and capture regression by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5250](kubernetes-sigs/external-dns#5250) - chore(openstack designate)!: remove in-tree provider by [@mloiseleur](https://github.com/mloiseleur) in [#5126](kubernetes-sigs/external-dns#5126) - chore(providers): rename custom TTL constants to defaultTTL by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5312](kubernetes-sigs/external-dns#5312) - chore: Release Helm chart v1.16.1 by [@stevehipwell](https://github.com/stevehipwell) in [#5270](kubernetes-sigs/external-dns#5270) - chore(release): updates kustomize & docs with v0.16.1 by [@mloiseleur](https://github.com/mloiseleur) in [#5184](kubernetes-sigs/external-dns#5184) - chore(source): code cleanup by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5304](kubernetes-sigs/external-dns#5304) - chore(webhook): bump cenkalti/backoff version by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5342](kubernetes-sigs/external-dns#5342) - test: add tests for cloudflare provider by [@natitomattis](https://github.com/natitomattis) in [#5248](kubernetes-sigs/external-dns#5248) - test(log): execute on multiple platforms by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5370](kubernetes-sigs/external-dns#5370) - test(log): fix random race detection by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5273](kubernetes-sigs/external-dns#5273) - test(source): cover unhappy paths by [@linoleparquet](https://github.com/linoleparquet) in [#5369](kubernetes-sigs/external-dns#5369) - test(source): fix data race on node_test by [@mloiseleur](https://github.com/mloiseleur) in [#5334](kubernetes-sigs/external-dns#5334) - test(source/pod): improve code coverage by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5378](kubernetes-sigs/external-dns#5378) - test(tlsconfig): add unit tests by [@linoleparquet](https://github.com/linoleparquet) in [#5381](kubernetes-sigs/external-dns#5381) - test(zone_filter): improve coverage from 66.7% to 100% by [@upsaurav12](https://github.com/upsaurav12) in [#5388](kubernetes-sigs/external-dns#5388) #### 📦 Docker Image docker pull registry.k8s.io/external-dns/external-dns:v0.17.0 #### New Contributors - [@ismailbaskin](https://github.com/ismailbaskin) made their first contribution in kubernetes-sigs/external-dns#5190 - [@lexisother](https://github.com/lexisother) made their first contribution in kubernetes-sigs/external-dns#5147 - [@tico24](https://github.com/tico24) made their first contribution in kubernetes-sigs/external-dns#5197 - [@t3mi](https://github.com/t3mi) made their first contribution in kubernetes-sigs/external-dns#5207 - [@octo](https://github.com/octo) made their first contribution in kubernetes-sigs/external-dns#5231 - [@xshot9011](https://github.com/xshot9011) made their first contribution in kubernetes-sigs/external-dns#5200 - [@tJouve](https://github.com/tJouve) made their first contribution in kubernetes-sigs/external-dns#5226 - [@Hayajiro](https://github.com/Hayajiro) made their first contribution in kubernetes-sigs/external-dns#5045 - [@davidwin93](https://github.com/davidwin93) made their first contribution in kubernetes-sigs/external-dns#5241 - [@vflaux](https://github.com/vflaux) made their first contribution in kubernetes-sigs/external-dns#5175 - [@arthlr](https://github.com/arthlr) made their first contribution in kubernetes-sigs/external-dns#5281 - [@semnell](https://github.com/semnell) made their first contribution in kubernetes-sigs/external-dns#5297 - [@BasJ93](https://github.com/BasJ93) made their first contribution in kubernetes-sigs/external-dns#5325 - [@natitomattis](https://github.com/natitomattis) made their first contribution in kubernetes-sigs/external-dns#5248 - [@riupie](https://github.com/riupie) made their first contribution in kubernetes-sigs/external-dns#5352 - [@lanandra](https://github.com/lanandra) made their first contribution in kubernetes-sigs/external-dns#5351 - [@smilutinovic-ionos](https://github.com/smilutinovic-ionos) made their first contribution in kubernetes-sigs/external-dns#5364 - [@linoleparquet](https://github.com/linoleparquet) made their first contribution in kubernetes-sigs/external-dns#5369 - [@kashalls](https://github.com/kashalls) made their first contribution in kubernetes-sigs/external-dns#5349 - [@matkam](https://github.com/matkam) made their first contribution in kubernetes-sigs/external-dns#3949 - [@upsaurav12](https://github.com/upsaurav12) made their first contribution in kubernetes-sigs/external-dns#5388 **Full Changelog**: kubernetes-sigs/external-dns@v0.16.1...v0.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: JesusMtnez <jesusmartinez93@gmail.com> Reviewed-on: https://codeberg.org/JesusMtnez/homelab/pulls/712 Co-authored-by: JesusMtnez-bot <jesusmartinez93+bot@gmail.com> Co-committed-by: JesusMtnez-bot <jesusmartinez93+bot@gmail.com>

hjoshi123 added 2 commits March 17, 2025 08:37

feat: added expose internal ipv6 flag

87e3c4b

Merge branch 'master' of github.com:hjoshi123/external-dns into feat-…

1fbcb57

…expose-internal-ipv6

k8s-ci-robot requested review from ivankatliarchuk and mloiseleur March 17, 2025 14:43

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2025

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2025

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 17, 2025

k8s-ci-robot changed the title ~~Feat expose internal ipv6~~ feat(source): optional expose of nodes internal ipv6 Mar 17, 2025

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 17, 2025

ivankatliarchuk suggested changes Mar 17, 2025

View reviewed changes

source/node.go Outdated Show resolved Hide resolved

source/node_test.go Outdated Show resolved Hide resolved

source/node_test.go Outdated Show resolved Hide resolved

source/node_test.go Outdated Show resolved Hide resolved

k8s-ci-robot assigned ivankatliarchuk Mar 17, 2025

hjoshi123 added 3 commits March 17, 2025 20:33

fix: removing fmt.Printf

ed2419a

fix: fixing ci lint

794cdd2

docs: added documentation in node source

1d61159

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2025

ivankatliarchuk suggested changes Mar 19, 2025

View reviewed changes

docs/sources/nodes.md Outdated Show resolved Hide resolved

pkg/apis/externaldns/types.go Outdated Show resolved Hide resolved

source/node_test.go Outdated Show resolved Hide resolved

edited docs and made new test

1bf31da

ivankatliarchuk suggested changes Mar 20, 2025

View reviewed changes

added warn log

bf43ddf

hjoshi123 requested a review from ivankatliarchuk March 21, 2025 20:45

jonasbadstuebner suggested changes Mar 24, 2025

View reviewed changes

detailed documentation with no-expose

df517cf

jonasbadstuebner suggested changes Mar 25, 2025

View reviewed changes

source/node.go Outdated Show resolved Hide resolved

hjoshi123 added 3 commits March 25, 2025 20:45

added new tests to handle edge case

af3a7df

renaming variable

04f1661

removing reduntant code

719cc78

ivankatliarchuk approved these changes Mar 26, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025

k8s-ci-robot merged commit a2f0f2e into kubernetes-sigs:master Mar 26, 2025
13 checks passed

ivankatliarchuk mentioned this pull request Mar 27, 2025

fix(node): logger test fixed #5232

Merged

2 tasks

mloiseleur mentioned this pull request Mar 31, 2025

Revert #3588 "IPv6 internal node IPs are usable externally" #4574

Closed

2 tasks

kevinvalk mentioned this pull request May 9, 2025

Flag --expose-internal-ipv6 does not apply to (headless) services using external-dns.alpha.kubernetes.io/endpoints-type annotation #5377

Closed

mloiseleur mentioned this pull request Jun 26, 2025

feat(nodes)!: expose external ipv6 by default #5575

Merged

3 tasks

jonasbadstuebner mentioned this pull request Jul 15, 2025

Flag --[no]-expose-internal-ipv6 does not apply to NodePort services #5651

Closed

feat(source): optional expose of nodes internal ipv6 #5192

feat(source): optional expose of nodes internal ipv6 #5192

Uh oh!

Conversation

hjoshi123 commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 17, 2025

Uh oh!

hjoshi123 commented Mar 17, 2025

Uh oh!

mloiseleur commented Mar 17, 2025

Uh oh!

mloiseleur commented Mar 17, 2025

Uh oh!

ivankatliarchuk commented Mar 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivankatliarchuk commented Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hjoshi123 commented Mar 20, 2025

Uh oh!

ivankatliarchuk Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

hjoshi123 Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

mloiseleur commented Mar 24, 2025

Uh oh!

jonasbadstuebner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 24, 2025

Uh oh!

jonasbadstuebner commented Mar 24, 2025

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 25, 2025

Uh oh!

ivankatliarchuk commented Mar 25, 2025

Uh oh!

jonasbadstuebner commented Mar 26, 2025

Uh oh!

ivankatliarchuk left a comment

Choose a reason for hiding this comment

Uh oh!

jonasbadstuebner commented Mar 26, 2025

Uh oh!

jonasbadstuebner commented Mar 26, 2025

Uh oh!

ivankatliarchuk commented Mar 26, 2025

Uh oh!

mloiseleur commented Mar 26, 2025

Uh oh!

k8s-ci-robot commented Mar 26, 2025

Uh oh!

Uh oh!

Uh oh!

hjoshi123 commented Mar 17, 2025 •

edited

Loading