feat(pubsub/v2): add back fake and internal packages #12292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shollyman
approved these changes
May 16, 2025
hongalex
added a commit
that referenced
this pull request
Jul 14, 2025
* move existing files to v2 * add pstest and testdata directories * chore(pubsub): rewrite v2 files with new package (#11292) * chore(pubsub): remove handwritten layer from v2 (#11367) * refactor imports to support v2 * remove handwritten schema client * remove handwritten topic admin methods * remove handwritten subscription admin methods * remove admin operations only tests * delete handwritten snapshot methods * deprecate(pubsub/v2): remove and rename existing settings (#11375) * deprecate(pubsub/v2): deprecate and rename user settings * remove more code related to synchronous and byte limit * refactor(pubsub/v2): make tests use new GAPIC library (#11429) * refactor(pubsub/v2): make tests use new GAPIC library * remove examples for list operations that are no longer part of this library * feat(pubsub/v2): rename data plane clients (#11376) * rename data plane clients * add renamed data clients * revert changes to filenames * rename subscriber * fix go docs referencing topic/subs * fix remaining data client renames * remove unused publisher method * remove TopicInProject remove TopicInProject * feat(pubsub): rename lease settings, change byte limit default (#11963) * chore(pubsub): restore updated v1 go files (#12011) * chore(pubsub): revert v2 gapic to head (#12090) * chore(pubsub): revert v2 gapic to HEAD * revert info.go changes * chore(pubsub): module and workspace updates (#12106) * chore(pubsub): replace go.mod and go.work files in v1 * fix go.work formatting * run go mod tidy * chore(pubsub): rename data plane clients (#12108) * chore(pubsub): rename data clients and update documentation * more data plane renaming * update repo-metadata and module files * update copyright header for new files * update go mod and work files * add deprecation notice for pubsub v1 * fix exported comments * feat(pubsub/v2): remove dependency on v2 fake (#12248) * remove v2 fake * remove lingering import of v2 pstest * run go mod tidy * bump google.golang.org/api version * feat(pubsub/v2): add back fake and internal packages (#12292) * feat(pubsub): add back v2 helper libraries * fix copyright header year for new files * update internal/testutil package version * chore: alias v1 pubsub types * chore(pubsub/v2): rename call options (#12519) * chore(pubsub/v2): rename call options * fix variable name * chore(pubsub/v2): carve out v2 module (#12509) * docs(pubsub): add migration guide to v2 (#12547) * docs(pubsub): add migration guide to v2 * additional code formatting and edits to migration guide * format code migration guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out a new v2 verison of the fake (package
pstest) is necessary after all. This is mostly because the fake takes in certain cloud.google.com/go/pubsub/apiv1/pubsubpb types as parameters which wouldn't be compatible with the pubsub/v2/apiv1/pubsubpb types. Since we plan on deprecating that first package, it's best to remove that dependency early and just release a fake v2.Also includes the internal packages since otherwise the v2 package will take a dependency on cloud.google.com/go/pubsub package, which is breaks the proto namespace (including schema.proto from different packages).
Replaces #12291