feat(pubsub/v2): add back fake and internal packages #12291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out a new v2 verison of the fake is necessary after all. This is mostly because the fake takes in certain cloud.google.com/go/pubsub/apiv1/pubsubpb types as parameters which wouldn't be compatible with the pubsub/v2/apiv1/pubsubpb types. Since we plan on deprecating that first package, it's best to remove that dependency early and just release a fake v2.
Also includes the internal packages since otherwise the v2 package will take a dependency on cloud.google.com/go/pubsub package, which is breaks the proto namespace (including schema.proto from different packages).