Use newer zstd, Assimp and GLFW to make build work with CMake 4.0 #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 4 removed compatibility with CMake <= 3.5, and the zstd version had it still as the minimum. Updated to latest zstd 1.5.7 to fix that.
Hopefully it didn't grow the bug zoo too much since 5.0.
5697046 to
850193b
Compare
The commit bumping to 3.5 (which is still too old) was just two weeks ago: bulletphysics/bullet3@d1a4256
5.2.0 also fails to build due to a missing <cstddef> include, which is fixed in 5.2.2. SIGH.
f073dc7 to
441c522
Compare
3.3.5, which is the oldest that has this fixed. Latest 3.4 relies on the wayland-scanner executable which isn't installed on the CI, and I don't want to deal with that as well.
441c522 to
770f25d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
CMake 4 removed compatibility with CMake <= 3.5, and various dependencies had that (or older) still as the minimum. Updated to newer versions to fix that. Assimp additionally needed to disable
-Werror, and for Bullet, where it still requires just CMake 2.4.3 (?!), I'm adding a workaround that CMake itself suggested.Prerequisite to make #2572 build on the Mac CI.