Update to latest Magnum and use the new text rendering APIs #2572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Depends on / based off #2573, which fixes one CI error.
Regular, 36th Magnum update. Main change is adapting to the new text rendering APIs, both in the C++ and Python code. Besides that:
std::string
-taking APIs in the Utility::String namespace are soon to be deprecated as all that functionality is available directly on Containers::StringView. While the deprecation markers are not in Corrademaster
yet, I updated Habitat code to not use those anymore.0xff3366_rgbf
now check at compile time that you pass exactly the amount of components needed for a RGB or RGBA color, preventing common errors. For example,0xff3366_rgbaf
wouldn't compile anymore, and neither would0xff3366aa_rgbf
.*.usd
files to AssimpImporter, which has opt-in support for those since version 5.4.3.How Has This Been Tested
🍏
viewer
locally, unfortunately I'm not able to test that my changes to the Python apps work as well. But I tried my best, used m.css-generated stubs for Magnum Python bindings in the IDE to spot typos, etc. Can you check those for me? @0mdc? Thanks.🤔 Apart from the CMake version error on the
build_conda_osx
job that's fixed by #2573, I have no idea what's up with the other conda job.