Skip to content

[12.x] Fix path to Str in exception markdown #56705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

[12.x] Fix path to Str in exception markdown #56705

merged 1 commit into from
Aug 21, 2025

Conversation

apreiml
Copy link
Contributor

@apreiml apreiml commented Aug 21, 2025

Otherwise showing an exception will fail with an exception, if the facade could not be found.

This error might have been introduced in v12.25.0

@apreiml
[12.x] Use full path to Str in exception markdown
2967be1 
Otherwise showing an exception will fail with an exception, if the
facade could not be found.

This error might have been introduced in v12.25.0
@apreiml apreiml changed the title [12.x] fix path to Str in exception markdown [12.x] Fix path to Str in exception markdown Aug 21, 2025
@taylorotwell taylorotwell merged commit a89e514 into laravel:12.x Aug 21, 2025
62 checks passed
@crynobone crynobone mentioned this pull request Aug 25, 2025
Closed
@AhmedAlaa4611
Copy link
Contributor

As @rodrigopedra said:

The \Illuminate\Support\Str is aliased to \Str by default. So it shouldn't be missing.

Unless you manually reset the aliases on a config file or on a service provider.

Please check if you are not resetting any aliases.

There could be a carried-over configuration from previous Laravel versions.

On prior Laravel versions, one could remove or add aliases on their ./config/app.php file.

I think we need to revert this one?

@rodrigopedra
Copy link
Contributor

@AhmedAlaa4611

Please read my comment on the related issue on my guess about the rationale behind this PR:

I guess more people reset their aliases, and it is better to not rely on class aliases on such a sensitive view.

Especially when the framework cannot guess in advance if the alias is available.

#56709 (comment)

It is best to be on the safe side, so IMO this PR is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apreiml @AhmedAlaa4611 @rodrigopedra @taylorotwell