WIP: Notify user when DMing a guest #1477
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taken from the "Icons" page in Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4031-32875&t=6FcBjNTASZoepny4-4
- Add realmEnableGuestUserDmWarning to PerAccountStore - Handle RealmUpdateEvent to keep setting in sync with server - Support feature level 348+ for realm configuration
0df0389 to
b3edf00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR adds support for warning users when they're messaging guest users in direct messages. It includes:
realmEnableGuestUserDmWarningproperty inPerAccountStoreRealmUpdateEventto keep this setting in sync with server changesThis feature requires Zulip server feature level 348 or higher.
Related Issues
Screenshots
Light mode
Dark mode