Wrap thumbnails in nav tag to get proper ARIA role
#663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running an accessibility test on a project using this package we found the following error: `aria-label attribute is not well supported on a div with no valid role attribute`. You could simply add a `role="navigation"` to the div, but changing the `div` to `nav` will do that and be more semantically correct.
xiaolin
pushed a commit
that referenced
this pull request
Jul 21, 2023
While running an accessibility test on a project using this package we found the following error: `aria-label attribute is not well supported on a div with no valid role attribute`. You could simply add a `role="navigation"` to the div, but changing the `div` to `nav` will do that and be more semantically correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running an accessibility test on a project using this package we found the following error:
aria-label attribute is not well supported on a div with no valid role attribute.You could simply add a
role="navigation"to the div, but changing thedivtonavwill do that and be more semantically correct.