feat: improve error handling #1132
Open
+67
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
endigma
reviewed
Apr 24, 2025
| @@ -703,7 +703,7 @@ func (r *Resolvable) addRejectFieldError(reason string, ds DataSourceInfo, field | |||
| } else { | |||
| errorMessage = fmt.Sprintf("Unauthorized to load field '%s', Reason: %s.", fieldPath, reason) | |||
| } | |||
| r.ctx.appendSubgraphError(goerrors.Join(errors.New(errorMessage), | |||
| r.ctx.appendError(goerrors.Join(errors.New(errorMessage), | |||
There was a problem hiding this comment.
appendError calls errors.Join inside, which takes a variadic second parameter, perhaps we could just pass this through to avoid nesting errors.Join calls and this odd goerrors alias?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleaned up error handling. Before, we joined errors twice, which resulted in duplicated error messages for subgraph access logs. I renamed
subgraphErrorstoerrorbecause it never only represented subgraph logs. I also wrapped the http client error with stack information for more verbose logs.