layout: Avoid setting baseline for phantom line boxes #54610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 31, 2025
Phantom line boxes should be treated as non-existing for most purposes, so don't let them affect the baseline of their block container. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
fc6316e to
4b3ed1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phantom line boxes should be treated as non-existing for most purposes, so don't let them affect the baseline of their block container.
Testing: An existing test passes, and also adding a new one which doesn't rely on
<button>Reviewed in servo/servo#39055