Canvas 2D globalHDRHeadroom: Enable PQ and HLG base gainmap image tests #54581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were disabled because of incorrect rendering of HLG and PQ ICC profiles. Allow some fairly significant error for the PQ version (4% in sRGB space) because both the PQ image and the gainmap image have substantial quantization error (it may be that I can re-make the jpeg images to at least have the error in the base image be compensated for in the gain image). Bug: 428575083 Change-Id: I150b19dff74b1fbd04eb027412ad2f83f003a3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6895248 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1507960}
wpt-pr-bot
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were disabled because of incorrect rendering of HLG and PQ ICC
profiles.
Allow some fairly significant error for the PQ version (4% in sRGB
space) because both the PQ image and the gainmap image have substantial
quantization error (it may be that I can re-make the jpeg images to at
least have the error in the base image be compensated for in the gain
image).
Bug: 428575083
Change-Id: I150b19dff74b1fbd04eb027412ad2f83f003a3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6895248
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1507960}