Fix css of WebVTT ref files to match real vtt cue settings #54392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom_override_cue_align_position_line_size_while_paused.html and
dom_override_cue_align_position_line_size.html give the vtt
cue the following settings:
c.align = 'start';
c.position = 80;
c.line = 0;
c.size = 20;
Align = "start" and position = 80 mean that the left edge of the cue
is positioned 80% of the video width (320px) to the right of the left edge
of the video. Currently the ref files set right: 51.2px on the fake cue
(16%). This should be changed to left: 80% to match the real vtt cue.
Additionally this patch changes width: 64px to width: 20% on the ref
cue for readability.
|
@zcorpan @gkatsev @alastor0325 could you take a look? |
|
OK so
The positioning logic was changed at some point (about a decade ago) without fixing the tests to match, so I suspect there are more tests that expect the old positioning logic. |
zcorpan
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dom_override_cue_align_position_line_size_while_paused.html and dom_override_cue_align_position_line_size.html give the vtt cue the following settings:
Align = "start" and position = 80 mean that the left edge of the cue is positioned 80% of the video width (320px) to the right of the left edge of the video. Currently the ref files set right: 51.2px on the fake cue (16%). This should be changed to left: 80% to match the real vtt cue. Additionally this patch changes width: 64px to width: 20% on the ref cue for readability.