[wasm] Upstream ESM Integration jsapi tests #53718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eqrion
approved these changes
Jul 29, 2025
| assert_equals(instance.exports.getGlobal(), 999); | ||
|
|
||
| instance.exports.setGlobal(888); | ||
| assert_equals(wasmNamespace.getGlobal(), 888); |
There was a problem hiding this comment.
Could we also assert that the same instance object is returned each call?
Is it also expected that doing multiple await import(X) for the same X will result in the same module namespace and instance objects?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstreams the new jsapi test suite from the WebAssembly ESM Integration per WebAssembly/esm-integration#110.
Some of these tests replicate functionality already in the webapi test suite, but also includes recent normative changes including:
wasm:andwasm-js:namespaces.WebAssemanbly.namespaceInstance(Instance lookup function for Wasm Namespaces WebAssembly/esm-integration#108)