Skip to content

Update: acknowledge the image role #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2024
Merged

Update: acknowledge the image role #533

merged 3 commits into from
Dec 13, 2024

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Dec 13, 2024 •
edited
Loading

role=image is the preferred default role, over the previous and still valid img role.

update the spec to call out the existence / allowance of the image role.

labels: needs implementation commitment, needs changelog entry

Closes #481

test case:

<div role=image>foo</div>
<!-- or -->
<div role=image aria-label=bar></div>

Preview | Diff

@scottaohara
Update: acknowledge the image role
d89cabf 
role=`image` is the preferred default role, over the previous and still valid `img` role.

update the spec to call out the existence / allowance of the `image` role.
scottaohara
scottaohara commented Dec 13, 2024
View reviewed changes
@scottaohara scottaohara added the Allowed roles Pertaining to the allowed roles of HTML elements label Dec 13, 2024
@scottaohara
Copy link
Member Author

though only 1 checker supports this for now, being that it's a role that all browsers support and is the preferred role for how browsers expose the img element - i have high confidence this is fine / checkers will update to account for it.

@scottaohara scottaohara merged commit 7f7718c into gh-pages Dec 13, 2024
2 checks passed
@scottaohara scottaohara deleted the add-image-role branch December 13, 2024 19:58
@scottaohara scottaohara added the Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge. label Dec 19, 2024
@SaekiTominaga SaekiTominaga mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Allowed roles Pertaining to the allowed roles of HTML elements Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mention of role=image
1 participant
@scottaohara