Skip to content

Conversation

stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Sep 26, 2019

Previously there was no definition of text-shadow composition. To match the behavior of other list-like properties such as transform lists (https://drafts.csswg.org/css-transforms-2/#combining-transform-lists) and box-shadow (#4374), this PR specs addition as list concatenation and accumulation as component-wise addition.

See #4330

@stephenmcgruer
Copy link
Contributor Author

Ping and cc @birtles

@fantasai
Copy link
Collaborator

If there's already a definition for addition and accumulation of shadows, why aren't we reusing it? I don't think text-shadow should get its own one-off definition here.

@stephenmcgruer
Copy link
Contributor Author

This may be overly pedantic. I'm not very familiar with box-shadow and text-shadow, so it's unclear to me whether they differ enough to have different definitions for addition/accumulation. I would have thought if they were alike enough then we would have extracted a common value for them out and could define things like computed-style and animation on that?

But if a css-text-decor-3 would rather we just point at https://drafts.csswg.org/web-animations-1/#animating-shadow-lists, I'm happy to do that. I feel it is important to do something here, since Chrome and Firefox ended up with different behaviors due to this not being defined in the specs.

@frivoal frivoal added the css-text-decor-3 Current Work label Jul 14, 2020
Base automatically changed from master to main February 2, 2021 19:45
@fantasai
Copy link
Collaborator

Committed cross-references between text-shadow and Web Animations' shadow lists. Closing out this PR. @stephenmcgruer Let me know if there's any problem (preferably by filing a new issue; I'm unlikely to notice replies here, tbh).

@fantasai fantasai closed this Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-text-decor-3 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants