Require all owning documents to have permission policy enabled #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is due to respec.org being down! |
rakuco
reviewed
Oct 18, 2023
index.html
Outdated
| If |document| is not [=allowed to use=] the [=policy-controlled | ||
| feature=] token "compute-pressure", return [=a promise rejected with=] {{NotAllowedError}}. | ||
| </ol> | ||
| </li> | ||
| <aside class="issue"> | ||
| <a href="https://github.com/wicg/compute-pressure/issues/110"> |
There was a problem hiding this comment.
Suggested change
| <a href="https://github.com/wicg/compute-pressure/issues/110"> | |
| <a href="https://github.com/w3c/compute-pressure/issues/110"> |
index.html
Outdated
| <aside class="issue"> | ||
| <a href="https://github.com/wicg/compute-pressure/issues/110"> | ||
| Permission policy doesn't support workers yet #110 | ||
| </a> | ||
| Permission policy doesn't support workers directly yet #110</a>, so they cannot be set per |
There was a problem hiding this comment.
Suggested change
| Permission policy doesn't support workers directly yet #110</a>, so they cannot be set per | |
| Permission policy does not support workers directly yet (#110)</a>, so they cannot be set per |
rakuco
reviewed
Oct 19, 2023
index.html
Outdated
| Shared workers often have multiple owning documents as they can be obtained | ||
| by other documents with the [=same origin=]. | ||
|
|
||
| In this case, all owning documents have to have the permission policy allowed |
There was a problem hiding this comment.
Is "have the permission policy allowed" a common way of phrasing this? It sounds a bit confusing.
There was a problem hiding this comment.
Yeah, I tried changing it a few times, but didn't find a good wording :-) Maybe @anssiko has some good suggestions
There was a problem hiding this comment.
How about just using allowed to use like in observe()?
"[...] all owning documents must be allowed to use the policy-controlled feature defined by this specification", for example.
Co-authored-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rakuco
Preview | Diff