Skip to content

Conversation

amadaluzia
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl
    • aarch64
    • aarch64-musl

Some extra notes

The post-patch phase is needed still it seems as removing it downloads skia 0.84.0. I should probably alert upstream to update the skia they are using so we don't have to do more wizardry to get around this in the future.

@amadaluzia
Copy link
Contributor Author

@theoheretic Just mentioning in case you don't see it. :)

@theoheretic
Copy link
Contributor

theoheretic commented Aug 5, 2025 via email

@amadaluzia
Copy link
Contributor Author

LGTM. I don't really have time to maintain void-packages anymore, as I have gotten myself caught up with other issues in life. If you are willing to take over the maintainership of neovide, that would be nice as I wouldn't have to worry about it. Thanks in advance :)

I'm happy to take over maintenance for neovide. Thanks for trusting me with that! 😄

@Duncaen
Copy link
Member

Duncaen commented Aug 11, 2025

We generally don't want people to adopt packages the first time they contribute, please mark it orphaned for now and when you have a few more contributions you can adopt the package. This is mainly because there are many on-off contributors and keeping track of who is still actively maintaining packages is getting complicated.

@amadaluzia
Copy link
Contributor Author

amadaluzia commented Aug 12, 2025

@Duncaen Fair enough, neovide has been orphaned.

@amadaluzia
Copy link
Contributor Author

amadaluzia commented Aug 12, 2025

Tests passed. I think this is ready to merge now. :)

@Duncaen Duncaen merged commit 7d991fd into void-linux:master Aug 12, 2025
8 checks passed
@classabbyamp classabbyamp mentioned this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants