Allow legacy renegotiation, and failing redirect detection #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you need to set |
To be honest, I don't remember the details… I tried again, and it seems to work without it, so I've dropped the change 🙂 |
b3fbe98 to
2840165
Compare
|
Could you take another look at this one, @vlaci? It'd be great to get it in 🙂 |
|
I also received this error. I fixed it with your patch. It would be nice if this were merged. |
|
This problem is definitely related to urllib3/urllib3#2653 |
enadeau
added a commit
to enadeau/openconnect-sso
that referenced
this pull request
Jun 19, 2024
enadeau
added a commit
to enadeau/openconnect-sso
that referenced
this pull request
Jun 20, 2024
|
@vlaci This PR is quite old — could you perhaps review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying out OpenConnect SSO on my Mac using OpenSSL 3, I get the follow error:
I addressed this by using setting the relevant flag on the SSL context. In addition, the redirect detection seemed to fail, so I suppressed the error and issued a warning instead. With those changes, I was able to connect to the VPN in question.
(This is replacement for #124 that targets
master. I haven't actually tested this branch, as I don't have PyQt6 installed at the moment.)Fixes #81.