Skip to content

fix: Fix DataContext lost on second HR on Android #19524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix: Fix DataContext lost on second HR on Android #19524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24cbecd
fix: Fix DataCOntext lost on second HR on Android
dr1rrb Feb 13, 2025
31dfc09
chore: Remove dead code
dr1rrb Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,6 @@ private static void SwapViews(FrameworkElement oldView, FrameworkElement newView
// need to swap the content of the page instead. This can happen if the Frame
// is using a native presenter which does not use the `Frame.Content` property.

// Clear any local context, so that the new page can inherit the value coming
// from the parent Frame. It may happen if the old page set it explicitly.

#if !WINUI
oldPage.ClearValue(Page.DataContextProperty, DependencyPropertyValuePrecedences.Local);
#else
oldPage.ClearValue(Page.DataContextProperty);
#endif

oldPage.Content = newPage;
#if !WINUI
newPage.Frame = oldPage.Frame;
Expand Down
0 src/Uno.UI/NativeFramePresenter.Android.cs → .../Controls/NativeFramePresenter.Android.cs
View file
Open in desktop
File renamed without changes.
Loading