fix(vs): Use single TFM build feature from VS #19440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport release/stable/5.6 |
✅ Backports have been created
|
dr1rrb
approved these changes
Feb 4, 2025
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19440/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19440/index.html |
jeromelaban
added a commit
that referenced
this pull request
Feb 4, 2025
…5.6/pr-19440 fix(vs): Use single TFM build feature from VS (backport #19440)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Removes workaround used to build a single target framework by rewriting the TFMs, instead use the ootb feature from VS. This also fixes multi-TFMs issues with
ENC1002: Cannot apply changes -- unexpected error: 'Object reference not set to an instance of an object.'Fixes #19433, fixes https://github.com/unoplatform/uno.hotdesign/issues/3290