Skip to content

introduce CT_BITWISE_AND as CT_ARITH #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

introduce CT_BITWISE_AND as CT_ARITH #4510

wants to merge 1 commit into from

Conversation

guy-maurel
Copy link
Contributor

@guy-maurel guy-maurel commented Apr 28, 2025 •
edited
Loading

PR #4510 is a bug fix proposal.
Please test it and report.
for the Issues #4505, #4502, #2205

This was referenced Apr 29, 2025
Open
Open
Closed
@briggsywxf
Copy link

Unfortunately this seems to not fix the issue in #4502 . The line in question is still formatted as if ((flags& MyEnum::FlagA) != MyEnum::Null) .
The parsing dump output also shows that the & is still parsed as a byref inside a c_cast, so it doesn't seem to be an issue with the config. Perhaps due to flags being parsed as TYPE even when it isn't and then we hit the assignment at line 1337 in these changes so the & is still set to CT_ADDR.

Is it worth adding the example given in #4502 as a test case? I can write it up properly as an additional test if needed.

@guy-maurel
Copy link
Contributor Author

I look...
Some more test data is always welcome!
Thanks

@briggsywxf
Copy link

briggsywxf commented Apr 30, 2025 •
edited
Loading

I look... Some more test data is always welcome! Thanks

I'll add a test and open it as a PR into this one

Edit: couldn't base it on this PR because it's coming from a fork too, but test at #4513

@briggsywxf briggsywxf mentioned this pull request Apr 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaurel gmaurel Awaiting requested review from gmaurel gmaurel is a code owner

@mwoehlke-kitware mwoehlke-kitware Awaiting requested review from mwoehlke-kitware mwoehlke-kitware is a code owner

@micheleCTDEAdmin micheleCTDEAdmin Awaiting requested review from micheleCTDEAdmin micheleCTDEAdmin is a code owner

@PoeticPeteAdmin PoeticPeteAdmin Awaiting requested review from PoeticPeteAdmin PoeticPeteAdmin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C and C++11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guy-maurel @briggsywxf @gmaurel