Skip to content

feat: enable services to register and receive operations from c8y #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

feat: enable services to register and receive operations from c8y #3747

merged 2 commits into from
Aug 1, 2025

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented Jul 29, 2025 •
edited
Loading

Proposed changes

Allow services to register and receive operations from c8y

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3226

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@albinsuresh albinsuresh temporarily deployed to Test Pull Request July 29, 2025 08:04 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
668 0 3 668 100 1h53m9.282944999s

@albinsuresh albinsuresh force-pushed the feat/3226/enable-operation-support-for-services branch from a1407a1 to 5ee8618 Compare July 29, 2025 08:51
@albinsuresh albinsuresh temporarily deployed to Test Pull Request July 29, 2025 08:51 — with GitHub Actions Inactive
@albinsuresh albinsuresh marked this pull request as ready for review July 29, 2025 08:52
rina23q
rina23q reviewed Jul 29, 2025
View reviewed changes
Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I have some minor suggestions.

@rina23q rina23q mentioned this pull request Jul 29, 2025
Open
@reubenmiller reubenmiller added the theme:mqtt Theme: mqtt and mosquitto related topics label Jul 31, 2025
reubenmiller
reubenmiller approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@reubenmiller reubenmiller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Everything looks fine, and I was able to create a customer operation handler for the Cumulocity service command (which is the end goal).

image

@reubenmiller
refactor system tests and move to dedicated suite
257e226 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request August 1, 2025 13:48 — with GitHub Actions Inactive
@reubenmiller reubenmiller enabled auto-merge August 1, 2025 14:08
@reubenmiller reubenmiller added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@reubenmiller reubenmiller added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@reubenmiller reubenmiller added this pull request to the merge queue Aug 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2025
@reubenmiller reubenmiller added this pull request to the merge queue Aug 1, 2025
Merged via the queue into thin-edge:main with commit cb958e1 Aug 1, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

@rina23q rina23q rina23q approved these changes

@didier-wenzek didier-wenzek Awaiting requested review from didier-wenzek didier-wenzek is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

Assignees
No one assigned
Labels
theme:mqtt Theme: mqtt and mosquitto related topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albinsuresh @reubenmiller @rina23q