Skip to content

test: Add tedge-p11-server compatibility suite #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

test: Add tedge-p11-server compatibility suite #3730

merged 1 commit into from
Jul 14, 2025

Conversation

Bravo555
Copy link
Member

Proposed changes

New compatibility.robot suite uses pinned tedge-p11-server to ensure new versions of thin-edge.io are backwards compatibile with tedge-p11-server.

Shared keywords were extracted into a resource file.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555 Bravo555 temporarily deployed to Test Pull Request July 11, 2025 11:35 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
665 0 3 665 100 1h49m29.248141s

@Bravo555 Bravo555 force-pushed the fix/tedge-p11-server-compat branch from f453d3b to 091690f Compare July 11, 2025 12:17
@Bravo555 Bravo555 temporarily deployed to Test Pull Request July 11, 2025 12:17 — with GitHub Actions Inactive
@Bravo555 Bravo555 marked this pull request as ready for review July 11, 2025 13:46
@Bravo555 Bravo555 requested a review from a team as a code owner July 11, 2025 13:46
@Bravo555 Bravo555 force-pushed the fix/tedge-p11-server-compat branch from 091690f to dfc13c7 Compare July 14, 2025 10:33
@Bravo555 Bravo555 temporarily deployed to Test Pull Request July 14, 2025 10:33 — with GitHub Actions Inactive
reubenmiller
reubenmiller reviewed Jul 14, 2025
View reviewed changes
@Bravo555 Bravo555 force-pushed the fix/tedge-p11-server-compat branch from dfc13c7 to 98102f8 Compare July 14, 2025 14:15
@Bravo555 Bravo555 had a problem deploying to Test Pull Request July 14, 2025 14:16 — with GitHub Actions Failure
@Bravo555
test(pkcs11): Add tedge-p11-server compatibility suite
753799c 
New compatibility.robot suite uses pinned tedge-p11-server to ensure new
versions of thin-edge.io are backwards compatibile with
tedge-p11-server.

Shared keywords were extracted into a resource file.

Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@Bravo555 Bravo555 force-pushed the fix/tedge-p11-server-compat branch from 98102f8 to 753799c Compare July 14, 2025 14:17
@Bravo555 Bravo555 temporarily deployed to Test Pull Request July 14, 2025 14:17 — with GitHub Actions Inactive
@reubenmiller reubenmiller added theme:testing Theme: Testing theme:hsm Hardware Security Module related topics labels Jul 14, 2025
@reubenmiller reubenmiller changed the title test(pkcs11): Add tedge-p11-server compatibility suite test: Add tedge-p11-server compatibility suite Jul 14, 2025
@Bravo555 Bravo555 enabled auto-merge July 14, 2025 14:40
@Bravo555 Bravo555 added this pull request to the merge queue Jul 14, 2025
Merged via the queue into thin-edge:main with commit 723e135 Jul 14, 2025
34 checks passed
@Bravo555 Bravo555 deleted the fix/tedge-p11-server-compat branch July 14, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

Assignees
No one assigned
Labels
theme:hsm Hardware Security Module related topics theme:testing Theme: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bravo555 @reubenmiller