Skip to content

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Add instructions and system tests for installing thin-edge.io on a device which is in a network behind a HTTP proxy

Note: Requires the following PR to be merged before the system tests will work:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request May 6, 2025 11:32 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the theme:connectivity Generic connectivity related stuff like HTTP proxy etc. label May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller marked this pull request as ready for review May 6, 2025 12:55
@reubenmiller reubenmiller requested review from a team and didier-wenzek as code owners May 6, 2025 12:55
@reubenmiller reubenmiller added the documentation Improvements or additions to documentation label May 6, 2025
Copy link
Contributor

github-actions bot commented May 6, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
629 0 3 629 100 1h51m48.019156s

@reubenmiller reubenmiller added this pull request to the merge queue May 6, 2025
Merged via the queue into thin-edge:main with commit d79d041 May 6, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation theme:connectivity Generic connectivity related stuff like HTTP proxy etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants