Skip to content

fix: Include name in tedge service registration message #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

fix: Include name in tedge service registration message #3592

merged 1 commit into from
May 5, 2025

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented May 5, 2025 •
edited
Loading

Proposed changes

Include name in tedge service registration message, along with type that already existed. This prevents the any auto-registration messages generated for the same service, with the name fragment, from conflicting with their initial explicit registration message.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3591

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@albinsuresh albinsuresh temporarily deployed to Test Pull Request May 5, 2025 06:09 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
627 0 3 627 100 1h52m39.938376999s

@albinsuresh albinsuresh marked this pull request as ready for review May 5, 2025 07:02
didier-wenzek
didier-wenzek approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The misleading error messages are correctly removed.

However we need to look for a longer term solution. See this comment #3591

@reubenmiller reubenmiller modified the milestone: 1.5.0 May 5, 2025
@albinsuresh albinsuresh force-pushed the fix/3591/include-name-in-tedge-service-registration-message branch from bd0fd78 to 6538442 Compare May 5, 2025 10:49
@albinsuresh albinsuresh temporarily deployed to Test Pull Request May 5, 2025 10:49 — with GitHub Actions Inactive
@albinsuresh albinsuresh added this pull request to the merge queue May 5, 2025
Merged via the queue into thin-edge:main with commit 7bcf609 May 5, 2025
34 checks passed
@albinsuresh albinsuresh mentioned this pull request May 6, 2025
Closed
@albinsuresh albinsuresh deleted the fix/3591/include-name-in-tedge-service-registration-message branch June 3, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@rina23q rina23q rina23q approved these changes

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albinsuresh @didier-wenzek @rina23q @reubenmiller