Skip to content

feat: support CSR file formats from gnutls certtool #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

feat: support CSR file formats from gnutls certtool #3556

merged 1 commit into from
Apr 14, 2025

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Apr 10, 2025 •
edited
Loading

Proposed changes

Improve the compatibility of the tedge with other tooling which can be used for creating Certificate Signing Requests (CSRs). For example, the gnutls certtool (which supports creating CSRs from private keys stored in HSMs via PKCS11)
processes CSR files which use an older BEGIN/END blocks, and can also contain additional details about the CSR in plain text (so it is readable for humans).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3546

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
supporting parsing CSR files from different tooling
a3abad5 
gnutls certtool (which supports creating CSRs from private keys stored in HSMs via PKCS11)
processes CSR files which use an older BEGIN/END blocks, and can also contain
additional details about the CSR in plain text (so it is readable for humans)

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request April 10, 2025 19:09 — with GitHub Actions Inactive
@reubenmiller reubenmiller added theme:cli Theme: cli related topics theme:certificates Theme: Device certificate topics labels Apr 10, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/cli/certificate/c8y/mod.rs 0.00% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
605 0 3 605 100 1h44m41.845095999s

didier-wenzek
didier-wenzek approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Apr 14, 2025
Merged via the queue into thin-edge:main with commit cb2afca Apr 14, 2025
51 of 52 checks passed
@reubenmiller reubenmiller deleted the feat-support-reading-certtool-csr branch April 14, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees
No one assigned
Labels
theme:certificates Theme: Device certificate topics theme:cli Theme: cli related topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reubenmiller @didier-wenzek