Skip to content

feat: Allow name and type in inventory.json #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

feat: Allow name and type in inventory.json #3419

merged 2 commits into from
Feb 28, 2025

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented Feb 25, 2025 •
edited by reubenmiller
Loading

Proposed changes

Allow name and type in inventory.json. The type value in inventory.json overrides the device.type value provided in the tedge.toml file.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/extensions/c8y_mapper_ext/src/converter.rs 0.00% 0 Missing and 1 partial ⚠️
crates/extensions/c8y_mapper_ext/src/inventory.rs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
583 0 3 583 100 1h34m4.675489999s

@albinsuresh albinsuresh force-pushed the feat/allow-name-type-inventory-json branch from 2e31d0c to b849329 Compare February 26, 2025 11:05
reubenmiller
reubenmiller reviewed Feb 27, 2025
View reviewed changes
didier-wenzek
didier-wenzek approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added the theme:telemetry Theme: Telemetry data label Feb 28, 2025
@albinsuresh albinsuresh force-pushed the feat/allow-name-type-inventory-json branch from 406c736 to 8c47f6d Compare February 28, 2025 19:50
@albinsuresh albinsuresh added this pull request to the merge queue Feb 28, 2025
Merged via the queue into thin-edge:main with commit f1e2a51 Feb 28, 2025
33 checks passed
@reubenmiller reubenmiller added this to the 1.5.0 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees
No one assigned
Labels
theme:telemetry Theme: Telemetry data
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@albinsuresh @reubenmiller @didier-wenzek