Skip to content

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Remove warning about some of the workflow features not being finalized.

In addition, some minor typos and consistencies were fixed (e.g. use "builtin" over "built-in" so the language reflects the workflow keyword builtin.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added documentation Improvements or additions to documentation theme:workflows Theme: Workflow engine topics labels Dec 7, 2024
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
529 0 2 529 100 1h29m3.807697s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Dec 9, 2024
Merged via the queue into thin-edge:main with commit eaa4c68 Dec 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation theme:workflows Theme: Workflow engine topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants