-
Notifications
You must be signed in to change notification settings - Fork 66
feat: add filtering to tedge config list
#3264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
69eb845
to
7066d85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Initially I was wondering if the filter value should have been behind a --filter
option or something like that. But, the proposed usage also looks quite natural.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition
feat: add filtering to `tedge config list`
Proposed changes
This adds an optional argument to
tedge config list
andtedge config list --doc
which filters the list of configuration keys shown, since the complete list is now very large.For example:
It uses a substring match, so it is easy to search for http related properties or certificate paths:
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments