Skip to content

feat: Add --log-level to tedge and c8y-remote-access-plugin #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: Add --log-level to tedge and c8y-remote-access-plugin #3254

merged 2 commits into from
Nov 19, 2024

Conversation

Bravo555
Copy link
Member

Proposed changes

Adds --log-level flag to previously missed tedge and c8y-remote-access-plugin components.

Together with #3205, the flag is present in these top-level components:

  • tedge
  • tedge-mapper
  • tedge-agent
  • tedge-watchdog
  • c8y-firmware-plugin
  • c8y-remote-access-plugin

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2089

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555 Bravo555 temporarily deployed to Test Pull Request November 18, 2024 15:06 — with GitHub Actions Inactive
jarhodes314
jarhodes314 reviewed Nov 18, 2024
View reviewed changes
crates/core/tedge/src/main.rs Outdated
tedge_config::TEdgeConfigLocation::from_custom_root(&config_dir);

log_init(
"tedge-mapper",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this argument does, but it looks like a copy and paste error

plugins/c8y_remote_access_plugin/src/lib.rs Outdated
@@ -40,6 +41,13 @@ pub async fn run(opt: C8yRemoteAccessPluginOpt) -> miette::Result<()> {
.into_diagnostic()
.context("Reading tedge config")?;

log_init(
"tedge-mapper",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark as above

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/c8y_remote_access_plugin/src/lib.rs 0.00% 6 Missing ⚠️
crates/core/tedge/src/main.rs 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
524 0 2 524 100 1h30m44.488723999s

@Bravo555 Bravo555 force-pushed the feat/2089/all-components branch from 71c9968 to fa1a97b Compare November 18, 2024 15:55
@Bravo555 Bravo555 temporarily deployed to Test Pull Request November 18, 2024 15:55 — with GitHub Actions Inactive
@Bravo555
Add --log-level to tedge
9582878 
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
@Bravo555
Add --log-level to remote access plugin
5dd8966 
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
@Bravo555 Bravo555 force-pushed the feat/2089/all-components branch from fa1a97b to 5dd8966 Compare November 19, 2024 09:50
@Bravo555 Bravo555 temporarily deployed to Test Pull Request November 19, 2024 09:50 — with GitHub Actions Inactive
@Bravo555 Bravo555 enabled auto-merge November 19, 2024 17:58
didier-wenzek
didier-wenzek approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Bravo555 Bravo555 added this pull request to the merge queue Nov 19, 2024
Merged via the queue into thin-edge:main with commit 14a8bda Nov 19, 2024
33 checks passed
@reubenmiller reubenmiller added this to the 1.4.0 milestone Dec 5, 2024
@reubenmiller reubenmiller changed the title Add --log-level to tedge and c8y-remote-access-plugin feat: Add --log-level to tedge and c8y-remote-access-plugin Dec 16, 2024
@reubenmiller reubenmiller added theme:troubleshooting Theme: Troubleshooting and remote control theme:cli Theme: cli related topics and removed theme:troubleshooting Theme: Troubleshooting and remote control labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarhodes314 jarhodes314 jarhodes314 left review comments

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@reubenmiller reubenmiller Awaiting requested review from reubenmiller

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees
No one assigned
Labels
theme:cli Theme: cli related topics theme:troubleshooting Theme: Troubleshooting and remote control
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Bravo555 @didier-wenzek @jarhodes314 @reubenmiller