Skip to content

fix: c8y http proxy wrongly assumes any hostname is from the same tenant #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: c8y http proxy wrongly assumes any hostname is from the same tenant #3222

merged 1 commit into from
Nov 5, 2024

Conversation

didier-wenzek
Copy link
Contributor

Proposed changes

When configured with hostnames without domains,
c8y_api::http_proxy::maybe_tenant_url wrongly assumes any hostname, given without a domain,
is related to the same tenant.

This was due to wrong defaults when parsing an url with no domain.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@didier-wenzek
c8y http proxy wrongly assumes any hostname is from the same tenant
bc27f63 
When configured with hostnames without domains,
c8y_api::http_proxy::maybe_tenant_url wrongly assumes any hostname,
given without a domain,
is related to the same tenant.

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
529 0 2 529 100 1h31m30.339443999s

@didier-wenzek didier-wenzek added this pull request to the merge queue Nov 5, 2024
Merged via the queue into thin-edge:main with commit 73b343e Nov 5, 2024
31 checks passed
@didier-wenzek didier-wenzek deleted the fix/maybe_tenant_url branch November 5, 2024 08:37
@reubenmiller reubenmiller added the theme:c8y Theme: Cumulocity related topics label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinsuresh albinsuresh albinsuresh approved these changes

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees
No one assigned
Labels
theme:c8y Theme: Cumulocity related topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@didier-wenzek @albinsuresh @reubenmiller