-
Notifications
You must be signed in to change notification settings - Fork 67
refactor: Simplify config manager control flow #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Simplify config manager control flow #3086
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have small cosmetic suggestion
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
97d9d18
to
a4f7a49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Proposed changes
As in #2904, control flow was simplified by replacing fragmented control flow and hashmaps with tokio tasks and regular async/await.
A test was added to confirm that requests are still processed concurrently.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments
Commits are kept small for ease of reviewing, once reviewed I'll merge them and add a description, unless it's not desired.
Fragmented uploads and downloads are only left in
FileCacheActor
andLogManagerActor
, I will do them in next PRs.