Skip to content

test: fix unit test to pass when the unit socket file exists #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

test: fix unit test to pass when the unit socket file exists #3041

merged 1 commit into from
Aug 1, 2024

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Aug 1, 2024

Proposed changes

Fix the issue of a unit test reported in #3007 (comment)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rina23q
Fix unit test to pass when the unit socket file exists
b79f03a 
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
@rina23q rina23q temporarily deployed to Test Pull Request August 1, 2024 11:33 — with GitHub Actions Inactive
@rina23q rina23q added theme:testing Theme: Testing theme:plugins Theme: Plugin interfaces or general plugin topics which don't fit in any other themes labels Aug 1, 2024
@rina23q rina23q requested a review from Bravo555 August 1, 2024 11:34
Bravo555
Bravo555 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@Bravo555 Bravo555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-term I think we should remove filesystem reads from the TryFrom<C8yRemoteAccessPluginOpt> for Command block, as it's really unexpected, but good to see the test working now.

@reubenmiller reubenmiller enabled auto-merge August 1, 2024 11:44
@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.0%. Comparing base (a3a5356) to head (b79f03a).
Report is 9 commits behind head on main.

Files Patch % Lines
plugins/c8y_remote_access_plugin/src/input.rs 75.0% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
plugins/c8y_remote_access_plugin/src/input.rs 80.3% <75.0%> (-0.6%) ⬇️

... and 7 files with indirect coverage changes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
490 0 2 490 100 1h22m20.870731999s

@reubenmiller reubenmiller added this pull request to the merge queue Aug 1, 2024
Merged via the queue into thin-edge:main with commit 635d25c Aug 1, 2024
33 checks passed
@rina23q rina23q deleted the test/3007/fix-unit-test branch August 1, 2024 12:29
@rina23q rina23q mentioned this pull request Aug 1, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bravo555 Bravo555 Bravo555 approved these changes

@didier-wenzek didier-wenzek Awaiting requested review from didier-wenzek didier-wenzek is a code owner

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

Assignees
No one assigned
Labels
theme:plugins Theme: Plugin interfaces or general plugin topics which don't fit in any other themes theme:testing Theme: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rina23q @Bravo555 @reubenmiller