Override whatwg-url to v14, fix punycode deprecation warning #2028
Conversation
|
Dug up this resolution comment (see other resolutions linked in there too): node-fetch/node-fetch#1793 (comment) Reverted the @MKRhere please have a look! |
|
Telegraf v4 started support with Node 12, and while that's too old now, I'm not sure if we should break compat within a major release. v5 is still a while away and it removes node-fetch completely in favour of native. I wonder if we should just request users to add overrides in newer versions of Node? Or considering Node may break compat in newer versions by removing the deprecated punycode module, perhaps we should break Node <18 compat after all, hmmm... |
|
Minor version 4 update dropping node <18 compat seems the way to go imo if v5 is too far away |
Closes #2027
Did not have much success in easily upgrading the node-fetch dependency here, also I'm not sure how much backward compatible you want to stay..? Breaking with node.js below v18 should be ok.
This is just the easiest step possible forward, and actual upgrade to node-fetch v3 is a lot more effort!
See https://github.com/node-fetch/node-fetch/blob/main/docs/v3-LIMITS.md