-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Revert "[Observation] ensure event triggers on deinitialization passes as if all properties that are being observed have changed (for weak storage) (#79823)" #83436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
phausler
wants to merge
1
commit into
swiftlang:main
Choose a base branch
from
phausler:pr/revert_observation_deinit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as if all properties that are being observed have changed (for weak storage) (swiftlang#79823)" This reverts commit 9d1d917.
stephentyrone
approved these changes
Jul 30, 2025
@swift-ci please test and merge |
phausler
added a commit
that referenced
this pull request
Aug 9, 2025
…ve active observations in memory (#82752)" (#83492) This reverts commit a349e64. This is in concert of #83436 <!-- If this pull request is targeting a release branch, please fill out the following form: https://github.com/swiftlang/.github/blob/main/PULL_REQUEST_TEMPLATE/release.md?plain=1 Otherwise, replace this comment with a description of your changes and rationale. Provide links to external references/discussions if appropriate. If this pull request resolves any GitHub issues, link them like so: Resolves <link to issue>, resolves <link to another issue>. For more information about linking a pull request to an issue, see: https://docs.github.com/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> <!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/main/docs/ContinuousIntegration.md#swift-ci Thank you for your contribution to Swift! -->
@swift-ci please test and merge |
stephencelis
added a commit
to pointfreeco/swift-perception
that referenced
this pull request
Aug 25, 2025
This brings in changes from swiftlang/swift#83436
stephencelis
added a commit
to pointfreeco/swift-perception
that referenced
this pull request
Aug 25, 2025
This brings in changes from swiftlang/swift#83436
It seems like CI got stuck? |
6 tasks
robmaceachern
added a commit
to square/workflow-swift
that referenced
this pull request
Sep 8, 2025
## Checklist **Bump perception to 2.0.6** **`tuist install --path Samples` to update Sample resolved dependencies** The Perception version specified in Package.swift is now `1.5.0"..<"3.0.0`. This allows easier upgrade and downgrades by consumers. I've opened this in favor of #376 because Perception has been [updated](pointfreeco/swift-perception#156) following Apple's reversion of swiftlang/swift#83436 and it avoids test updates on our end for now. I didn't run the `tuist install` with the `--update` flag this time either. There doesn't seem to be a way to scope the updates to only Perception and it's sub-dependencies and I didn't want all the other clutter associated with this change. - [x] Unit Tests - [x] UI Tests - [x] Snapshot Tests (iOS only) - [x] I have made corresponding changes to the documentation - [x] Resolve new Perception warning in ios-register: squareup/ios-register#131811 - [x] Resolve new instances of Perception warnings in Market: squareup/market#11042 --------- Co-authored-by: Andrew Watt <100192+watt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9d1d917.