-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: Add CI workflows #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CI workflows #2789
Conversation
Is there any filter that if PR has e.g. README.md update or other files/folders (we could add to the filter later on) then this GitHub Action wouldn't be triggered? For example this action https://github.com/stride3d/stride-website/blob/master/.github/workflows/stride-website-release-azure.yml has |
01a3a8c
to
033454b
Compare
@VaclavElias I've added paths as suggested. Let me know what you think. |
-<BuildProperties>Configuration=Release;NoWarn=1591;DeployExtension=false;StridePlatforms=$([MSBuild]::Escape('$(StridePlatforms)'));StrideGraphicsApiDependentBuildAll=$(StrideGraphicsApiDependentBuildAll)</BuildProperties>
+<BuildProperties>NoWarn=1591;DeployExtension=false;StridePlatforms=$([MSBuild]::Escape('$(StridePlatforms)'));StrideGraphicsApiDependentBuildAll=$(StrideGraphicsApiDependentBuildAll)</BuildProperties>
edit: I've changed my mind. The new build jobs will not use |
374fb25
to
dbee57b
Compare
@VaclavElias @xen2 as far as I'm concerned the PR is ready. The only remaining task before merging is the configuration on the repository itself. Let me know when that part is done so I can merge. |
I have updated action permissions (I checked each of them and ended up with same choices as yours). |
PR Details
Add CI workflows that will run when PRs are opened, updated and merged.
The workflows can also be triggered manually if necessary.
Results on my fork
Notes
Before merging, it would be good to restrict who can run workflows and use the most conservative settings at the beginning. As an example, here what I have on my fork:
Types of changes
Checklist