fix: output directories of DxtWrapper and re-builds with MSVC v143 #2694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dlls were built using `sources\tools\Stride.TextureConverter.Wrappers\build-deps.bat` inside of developer command prompt of VS2022
8 tasks
|
Thank you Azeno! I can confirm with your branch I am able to now build on win-64 without the texture issues: I did have to change the Stride.Native.Targets to make the arm setting false but I will redo my PR and try to follow your suggestion of the Stride.Build config changes. |
|
Thanks ! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dlls were built using
sources\tools\Stride.TextureConverter.Wrappers\build-deps.batinside of developer command prompt of VS2022PR Details
After #2644 dds files did no longer load on
win-x64. That PR changed the string marshalling fromAutotoAnsi, which is correct if we look at the native call site (stride/sources/tools/Stride.TextureConverter.Wrappers/DxtWrapper/dxt_wrapper.h
Line 40 in 1925a7b
This PR fixes that, by re-building those native assets with current compiler (MSVC v143) as well.
Related Issue
#2693
Types of changes
Checklist