refactor: Modernize script templates #2662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kryptos-FR
reviewed
Mar 7, 2025
sources/editor/Stride.Assets.Presentation/Templates/Assets/Scripts/Events/EventListener.cs
Outdated
Show resolved
Hide resolved
|
For consistency, I also updated android and ios project templates |
Kryptos-FR
approved these changes
Mar 7, 2025
|
Thanks ! |
Ethereal77
reviewed
Mar 30, 2025
| { | ||
| if (Input.IsKeyDown(Keys.LeftShift) && Input.IsKeyDown(Keys.LeftCtrl) && Input.IsKeyReleased(Keys.P)) | ||
| if (simulation != null) | ||
| { | ||
| if (simulation != null) |
There was a problem hiding this comment.
Double if with the same condition. Also, not very important, but isn't it better now to is not null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
PR modernizes current script templates mainly by using file-scoped namespaces
Types of changes
Checklist