Skip to content

refactor: Nullable and Modernization for Core Assets projects #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 4, 2025
Merged

refactor: Nullable and Modernization for Core Assets projects #2658

merged 11 commits into from
Mar 4, 2025

Conversation

Kryptos-FR
Copy link
Member

@Kryptos-FR Kryptos-FR commented Mar 1, 2025 •
edited
Loading

PR Details

Similar to #2639, #2643 and #2654.

Description

Affected projects:

  • Stride.Core.BuildEngine.Common
  • Stride.Core.Packages
  • Stride.Core.Assets
  • Stride.Core.Assets.Tests
  • Stride.Core.Assets.Yaml
  • Stride.Core.Assets.Quantum
  • Stride.Core.Assets.Quantum.Tests
  • xunit.runner.stride

Related Issue

#2155
#2156

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR Kryptos-FR added area-Asset area-Core Issue of the engine unrelated to other defined areas labels Mar 1, 2025
@Kryptos-FR Kryptos-FR force-pushed the feature/modernize-code-assets branch 2 times, most recently from 6f0e78e to ad1a1c2 Compare March 1, 2025 22:48
@Kryptos-FR Kryptos-FR force-pushed the feature/modernize-code-assets branch from ad1a1c2 to 5b2094f Compare March 2, 2025 17:05
@Kryptos-FR Kryptos-FR force-pushed the feature/modernize-code-assets branch from 5b2094f to f824598 Compare March 2, 2025 18:21
@Kryptos-FR Kryptos-FR marked this pull request as ready for review March 2, 2025 18:47
Jklawreszuk
Jklawreszuk reviewed Mar 4, 2025
View reviewed changes
Jklawreszuk
Jklawreszuk reviewed Mar 4, 2025
View reviewed changes
Jklawreszuk
Jklawreszuk reviewed Mar 4, 2025
View reviewed changes
Jklawreszuk
Jklawreszuk approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@Jklawreszuk Jklawreszuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I missed something, these changes are all good for me

@Kryptos-FR Kryptos-FR merged commit cb520de into stride3d:master Mar 4, 2025
5 checks passed
@Kryptos-FR Kryptos-FR deleted the feature/modernize-code-assets branch March 4, 2025 16:33
@Kryptos-FR
Copy link
Member Author

Kryptos-FR commented Mar 4, 2025 •
edited
Loading

PR with conflicts following the merge:

Kryptos-FR added a commit to Kryptos-FR/stride that referenced this pull request May 12, 2025
@Kryptos-FR
[Launcher] Fix build after stride3d#2658 and stride3d#2683
1a613f0
@Kryptos-FR Kryptos-FR mentioned this pull request May 12, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Jklawreszuk Jklawreszuk Jklawreszuk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-Asset area-Core Issue of the engine unrelated to other defined areas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kryptos-FR @Jklawreszuk