fix: Resolve crashing issue for OpenGL UIPage (#2189) #2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ping @MeharDT, because I think you'll be interested in a fix |
Jklawreszuk
commented
Oct 24, 2024
| @@ -930,29 +929,21 @@ public unsafe MappedResource MapSubresource(GraphicsResource resource, int subRe | |||
|
|
|||
| GL.BindBuffer(buffer.BufferTarget, buffer.BufferId); | |||
|
|
|||
| #if !STRIDE_GRAPHICS_API_OPENGLES | |||
| //if (mapMode != MapMode.WriteDiscard && mapMode != MapMode.WriteNoOverwrite) | |||
There was a problem hiding this comment.
I don't quite know what this code does but it seems to be possible to get rid of it since it hasn't been used since Paradox Engine
|
Thanks ! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR fixes incorrect buffer clearing for OpenGL when mapping a resource. It turns out that IntPtr.Zero was treated as some kind of value while this was not the author's intention. I also did a small refactoring
Related Issue
Types of changes
Checklist