feat: [Physics] Adding margins to convex hull colliders (Issue1577) #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added margin field to parent class ColliderShape, therefore all collider shapes can have access.
…llColliders_FeatureEnhancement
|
@dotnet-policy-service agree
|
Eideren
reviewed
May 22, 2024
| /// The Margin of the generated convex hull. | ||
| /// </userdoc> | ||
| [DataMember(48)] | ||
| public float Margin { get; set; } |
There was a problem hiding this comment.
Just a small note, it looks like margins in bullet by default should be around 0.04 for dynamic and 0.0 for static objects. Convex hulls are likely used as replacement for the lack of support of non-static meshes, so best set it to the default value for dynamics, so 0.04 by default.
There was a problem hiding this comment.
Good call, adding that now
Context: Margins in bullet by default should be around 0.04 for dynamic and 0.0 for static objects. Convex hulls are likely used as replacement for the lack of support of non-static meshes, so best set it to the default value for dynamics, so 0.04 by default.
…llColliders_FeatureEnhancement
|
Looks good, thanks a bunch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Allow specification of margin for collider shapes. Shows to be useful for ConvexHull colliders.
Description
Margin property now able to be set on ConvexHull collider shape. Added margin getter and setting vars onto ConvexHullColliderShape as well as the viewable field in the properties box for the user to adjust. The base class ColliderShape contains where margin is defined as recommened so all collider shapes can potentially benefit from the new variable.
Related Issue
Link to issue:
#1577
Link to initial discussion:
#1574
Motivation and Context
Originally reported as a missing field that solves an issue related to a test project not being able to adjust the corresponding collider. This margin not being able to be adjusted was causing unintended collisions and not allowing the user to be able to properly set up their ConvexHullCollider properties to fix the problem in the property box.
For additonal testing, I made a fork of the users orignal project that showcases the issue here:
https://github.com/dloe/StrideEngineIssue1577_RigidBodyPhysicsBugProject
Types of changes
Checklist