Skip to content

[Build] Require VC++ 2019 redist minimum #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2024
Merged

[Build] Require VC++ 2019 redist minimum #2100

merged 1 commit into from
Jan 11, 2024

Conversation

Kryptos-FR
Copy link
Member

PR Details

Update the minimum required VC++ redist to 2019.

Description

We were still requiring VC++ 2013 when building a game from Visual Studio. However, the dependency was updated to VC++ 2019 in commits ed09ac0 and 4571b04.

Related Issue

Discussion: #1498

Motivation and Context

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR
Copy link
Member Author

Kryptos-FR commented Jan 10, 2024 •
edited
Loading

Confirmed working on a Sandbox (with Stride 4.1).

image

Minimal install: SDK + running dotnet restore and dotnet build.

note: Physics sample was modified to include a hull decomposition.

@Kryptos-FR Kryptos-FR marked this pull request as ready for review January 10, 2024 22:12
@Eideren Eideren requested a review from xen2 January 11, 2024 02:39
xen2
xen2 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@xen2 xen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I double checked, the prerequisites installer was already bumped to install only VS2019 (and not VS2013 anymore).

@Kryptos-FR Kryptos-FR merged commit be7126f into stride3d:master Jan 11, 2024
@Kryptos-FR Kryptos-FR deleted the feature/vcredist-check-update branch January 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xen2 xen2 xen2 approved these changes

Assignees
No one assigned
Labels
area-Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kryptos-FR @xen2 @VaclavElias