Skip to content

Remove docs, has been moved to Stride docs repo #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2024
Merged

Remove docs, has been moved to Stride docs repo #2036

merged 2 commits into from
Feb 11, 2024

Conversation

Aggror
Copy link
Member

@Aggror Aggror commented Nov 13, 2023

PR Details

The docs folder in the Stride folder has been moved to the official Stride 3d repo and can be seen published here:
https://doc.stride3d.net/latest/en/contributors/engine/architecture/index.html

1 file that needs to be reviewed before moving to Official Stride docs is Copy-paste.md

Motivation and Context

Keeping all docs in 1 place as much as possible.

Types of changes

  • [ x] Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x ] My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Copy link
Collaborator

Eideren commented Jan 20, 2024

What's the issue with Copy-paste.md exactly, not sure what I should review ? We could move it to the website and review it over there instead ?

@VaclavElias
Copy link
Contributor

This one https://github.com/stride3d/stride/blob/master/docs/technical/copy-paste.md

@Eideren
Copy link
Collaborator

Eideren commented Jan 20, 2024

Sure, but what's the issue exactly ?

@VaclavElias
Copy link
Contributor

Is the content relevant in that file,do we need it, and where it should be moved to our Stride Docs.

@Eideren
Copy link
Collaborator

Eideren commented Jan 20, 2024

Yep, in architecture next to the rest of them https://doc.stride3d.net/latest/en/contributors/engine/architecture/index.html

@VaclavElias VaclavElias self-assigned this Jan 22, 2024
@VaclavElias VaclavElias added the area-Doc Issues related to documentation and XML comments label Jan 22, 2024
@VaclavElias VaclavElias mentioned this pull request Jan 22, 2024
Merged
@VaclavElias
Copy link
Contributor

Hey @Aggror, I moved copy-paste.md here https://github.com/stride3d/stride-docs/blob/master/en/contributors/engine/architecture/copy-paste.md

Please, double, triple check if you would like this PR being merged, so we don't lose removed content.

@Aggror
Copy link
Member Author

Aggror commented Feb 10, 2024

@VaclavElias With that file moved, we can go ahead and remove this folder.
Everything should reside in the docs contributor section now.

@Aggror Aggror merged commit f650051 into stride3d:master Feb 11, 2024
@Aggror Aggror deleted the remove-docs-folder branch December 9, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VaclavElias VaclavElias

Labels
area-Doc Issues related to documentation and XML comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aggror @Eideren @VaclavElias